Skip to content

Conversation

@unDemian
Copy link
Contributor

@unDemian unDemian commented Apr 3, 2018

Built on top of #196

Summary

Currently the Happychat client is selecting the color theme based on the groups sent via parameters. This PR updates that behavior and now themes will be selected based on a theme parameter.

There are 2 reasons for this change, first of all groups are deprecated and will be replaced by skills soon. Also at least in calypso we have scenarios where a chat could be part of jpop product but we still need the calypso theme to be loaded.

Testing

  1. Run npm start
  2. Open http://localhost:9000
  3. It should load jetpack's color scheme
  4. Update the targets/standalone/example.html theme option to either calypso or woo
  5. Run npm start again
  6. It should change the color scheme to the one selected.

@unDemian unDemian requested a review from oandregal May 4, 2018 13:24
@unDemian unDemian mentioned this pull request May 4, 2018
@oandregal
Copy link
Contributor

This should have been addressed by #241

@oandregal oandregal removed their request for review February 6, 2019 08:27
@unDemian unDemian removed the request for review from a team December 28, 2021 08:49
@unDemian unDemian removed their assignment Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants