Skip to content

PNPM config: exclude wp and woo packages from minimum age limit#46124

Merged
tbradsha merged 1 commit intotrunkfrom
update/pnpm-config-exclude-from-minimum-release-age
Nov 28, 2025
Merged

PNPM config: exclude wp and woo packages from minimum age limit#46124
tbradsha merged 1 commit intotrunkfrom
update/pnpm-config-exclude-from-minimum-release-age

Conversation

@simison
Copy link
Member

@simison simison commented Nov 27, 2025

Follow-up to #46002 (comment) and discussed in Slack, internal ref p1764169393421879-slack-C45SNKV4Z

Came up when updating WP-DataViews: #45914 (comment)

Proposed changes:

  • Adds @wordpress and @woocommerce packages as something we often work on within the company, and don't want to slow down workflows by requiring wait time between updating package and integrating with Jetpack.
  • Simplified code comment

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@simison simison requested a review from a team November 27, 2025 14:56
@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Build labels Nov 27, 2025
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@simison simison mentioned this pull request Nov 27, 2025
3 tasks
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thanks!

@tbradsha tbradsha force-pushed the update/pnpm-config-exclude-from-minimum-release-age branch from 8e22494 to 31ff271 Compare November 28, 2025 16:12
@tbradsha
Copy link
Contributor

Rebased due to #46126.

@tbradsha tbradsha merged commit 96f68db into trunk Nov 28, 2025
65 checks passed
@tbradsha tbradsha deleted the update/pnpm-config-exclude-from-minimum-release-age branch November 28, 2025 16:26
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants