Forms: Set "from" field as primary on dashboard#46170
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
| .jp-forms__inbox__author-field__email { | ||
| font-size: 11px; | ||
| filter: opacity(0.8); | ||
| filter: opacity(0.6); |
There was a problem hiding this comment.
Because by changing the field to a titleField the color and weight are changed automatically as well. With the darker color, the 0.8 opacity looks too dark for the secondary information, so I reduced it to 0.6 to account for that.
You can test it in the browser to see the difference, I think you'll agree.
There was a problem hiding this comment.
Yes this make sense to make! Nice touch 💅
|
Nice fix @dhasilva! |
Fixes an issue introduced when updating the dataviews package, where the column spacing is broken
Update PR: #45914
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
pnpm installand restart watch build