Skip to content

Fix AI Assistant modal shaking when content streams in #47616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CGastrell wants to merge 3 commits into
base: trunk
Choose a base branch
from
+22 −17
Open

Fix AI Assistant modal shaking when content streams in #47616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c728436
AI Client: Fix modal header spacing and make it sticky
CGastrell Mar 16, 2026
fe35b06
Jetpack: Align AI modal consumer spacing with updated modal padding
CGastrell Mar 16, 2026
e737186
Add changelog entries.
invalid-email-address Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/ai-client/changelog/pr-47616
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

AI Assistant: Fix modal shaking when content streams in by correcting header margins and making the header sticky.
1 change: 0 additions & 1 deletion projects/js-packages/ai-client/src/components/modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export default function AiAssistantModal( {
>
<div className="ai-assistant-modal__content" style={ { maxWidth } }>
<ModalHeader requestingState={ requestingState } onClose={ handleClose } title={ title } />
<hr className="ai-assistant-modal__divider" />
{ children }
</div>
</Modal>
Expand Down
16 changes: 7 additions & 9 deletions projects/js-packages/ai-client/src/components/modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,14 @@
&__header {
display: flex;
justify-content: space-between;
margin-right: -32px;
margin-left: -32px;
margin-top: -32px;
margin-right: -24px;
margin-left: -24px;
margin-top: -24px;
padding: 8px 12px;
}

&__divider {
background: #dcdcde;
margin: 0 -32px;
height: 1px;
position: sticky;
top: -24px;
background: #fff;
border-bottom: 1px solid #dcdcde;
}

&__title-wrapper {
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/pr-47616
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

AI Assistant: Fix modal shaking when content streams in by correcting header margins and making the header sticky.
4 changes: 2 additions & 2 deletions ...cts/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/feedback/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
.ai-assistant-post-feedback {

&__suggestion {
padding: 18px 0;
margin-bottom: -32px;
padding: 8px 0;
margin-bottom: -16px;

ul,
ol {
Expand Down
10 changes: 5 additions & 5 deletions ...s/jetpack/extensions/plugins/ai-assistant-plugin/components/title-optimization/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
&__footer {
display: flex;
justify-content: flex-start;
margin-right: -32px;
margin-left: -32px;
margin-top: 32px;
margin-bottom: -32px;
padding: 20px 32px;
margin-right: -24px;
margin-left: -24px;
margin-top: 24px;
margin-bottom: -24px;
padding: 20px 24px;
border-top: solid 1px #dcdcde;
height: 60px;
}
Expand Down
Loading