Open
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 94.87% 93.92% -0.95%
==========================================
Files 6 6
Lines 390 395 +5
==========================================
+ Hits 370 371 +1
- Misses 20 24 +4
Continue to review full report at Codecov.
|
mathieudutour
requested changes
Apr 28, 2020
Collaborator
mathieudutour
left a comment
mathieudutour
left a comment
There was a problem hiding this comment.
That sounds sensible. Could you add some docs and tests for it?
| * @return {Promise} | ||
| */ | ||
|
|
||
| Manager.prototype.reconnect = function () { |
Collaborator
There was a problem hiding this comment.
could you add an fn argument to be consistent with the open method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code to reconnect when 'useUnifiedTopology': false.
When 'useUnifiedTopology': true, this should be built-in