Add Windows ARM64 prebuild configuration#1957
Open
dennisameling wants to merge 2 commits intoAutomattic:masterfrom
Open
Add Windows ARM64 prebuild configuration#1957dennisameling wants to merge 2 commits intoAutomattic:masterfrom
dennisameling wants to merge 2 commits intoAutomattic:masterfrom
Conversation
Collaborator
|
Cool! Did you by chance try cross-compiling? |
|
I get a feeling this no longer needed: |
64ed3d8 to
ff0f2ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a prebuild configuration for Windows ARM64. I've been adding the necessary packages to MSYS2
clangarm64(they will be published in the coming weeks):GitHub Actions doesn't have ARM64 runners yet, so for now, this allows folks to create prebuilds locally. An example build can be found here: https://github.com/dennisameling/node-canvas/releases/tag/v2.8.0-arm64
Result of
npm test:Test results