Draft
Conversation
Collaborator
|
The only change from v2 to v3 was increasing the minimum node version. Can you upgrade instead? |
Author
|
Very much stuck on Node 16 currently |
Author
|
Could v3 be made Node16 compatible? |
Collaborator
|
My memory is that v3 runs in node 16 just fine, but node-addon-api doesn't officially support it. I would give it a shot. I don't think I have the amount of time it takes to get the old build scripts for v2 working again, but there has been a lot of pressure to do so. |
Author
|
So v2 can't actually be built now? Hence v3? |
Author
|
|
Collaborator
|
I think we bumped node to 18 because the earlier versions aren't supported anymore, not due to any changes to node-canvas: #2310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to just help with some minor Electron issues we had.
Can a collaborator make a
v2.xbranch off ofv2.11.2to put this into please? Then I can change PR target to that