Improve debug attachment with download attempt time and playback issues #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekygecko
added
[Type] Enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the debug attachment generated for support by improving the formatting and content of episode issue reporting. The changes make it easier to correlate user support requests with specific issues by adding timestamps and organizing information more clearly.
Key changes:
- Added playback issues section alongside existing download issues
- Ordered both issue types by attempt time (most recent first) with human-readable timestamps
- Converted some blocking database calls to proper coroutine/suspend functions
- Improved section header formatting to be dynamically sized
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Support.kt | Main changes: refactored debug output to include playback issues, added timestamp formatting, improved section headers, and removed runBlocking calls |
| PodcastManager.kt | Added suspend function interface for countPodcasts() |
| PodcastManagerImpl.kt | Implemented the new suspend countPodcasts() function |
| PodcastDao.kt | Added suspend database query function count() |
...es/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/support/Support.kt
Outdated
Show resolved
Hide resolved
...es/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/support/Support.kt
Outdated
Show resolved
Hide resolved
geekygecko
requested review from
Copilot and
sztomek
and removed request for
a team
...es/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/support/Support.kt
Outdated
Show resolved
Hide resolved
…/pocketcasts/repositories/support/Support.kt Fix unit pluralisation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes some improvements to the support debug attachement.
Before
After
Testing Instructions
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...