Add unit tests for startEnvironment() readiness polling and retry logic#2743
Draft
Copilot wants to merge 3 commits intocommander-migrationfrom
Draft
Add unit tests for startEnvironment() readiness polling and retry logic#2743Copilot wants to merge 3 commits intocommander-migrationfrom
Copilot wants to merge 3 commits intocommander-migrationfrom
Conversation
Co-authored-by: rinatkhaziev <459254+rinatkhaziev@users.noreply.github.com>
Co-authored-by: rinatkhaziev <459254+rinatkhaziev@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] WIP Address feedback on Commander migration pull request
Add unit tests for startEnvironment() readiness polling and retry logic
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
startEnvironment()function gained bounded readiness polling and a recoverylandoStart()retry pass, but had no test coverage for those branches — leaving success/retry/failure paths unverified and prone to silent regression.Changes
dev-environment-lando– addedjest.mockfor the lando module and imports forisEnvUp,landoStart,landoRebuild,getProxyContainer,landoInfoso each test can control readiness behavior independently.startEnvironmenttest cases under areadiness polling and retrydescribe block:isEnvUpreturnstrueimmediately; asserts no retrylandoStartis issued.isEnvUpexhausts all 6 first-pass attempts, then resolves on the second pass; assertslandoStartretry fires exactly once andisEnvUpis called 7 times total.isEnvUpalways returnsfalse; asserts both passes exhaust all 12 attempts and aUserErroris thrown.jest.useFakeTimers()+jest.runAllTimersAsync()to avoid real 2-second sleep delays. The failure-case rejection handler is registered beforerunAllTimersAsync()to prevent spurious unhandled-rejection failures.fs.readFileSyncmock – intercepts only theinstance_data.jsonpath to avoid corrupting lazy module loads (e.g. chalk) during test execution.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.