Skip to content

fix: preparation to opensource the block explorer#325

Merged
nahuseyoum merged 8 commits intomainfrom
SYS-4780-opensourcing-block-explorer
Dec 17, 2025
Merged

fix: preparation to opensource the block explorer#325
nahuseyoum merged 8 commits intomainfrom
SYS-4780-opensourcing-block-explorer

Conversation

@ivan-cholakov
Copy link
Contributor

@ivan-cholakov ivan-cholakov commented Dec 4, 2025

PR: Open Source Preparation for Block Explorer

Summary

This PR prepares the dApps repository for open-sourcing by addressing security vulnerabilities, cleaning up code, standardizing licensing, and adding essential open-source governance files.

Changes

Security Vulnerability Fixes

Updated dependencies to patch known security vulnerabilities:

Package Previous Version New Version Severity CVE/Advisory
axios ^0.21.1 / ^1.2.2 ^1.8.2 High SSRF and Credential Leakage
express ^4.17.1 ^4.20.0 Low XSS via response.redirect()
graphql ^16.6.0 ^16.8.1 Moderate Uncontrolled Resource Consumption
next 14.2.9 / ^14 14.2.32 / ^14.2.32 Critical Authorization Bypass in Middleware
eslint-config-next 14.2.9 14.2.32 - Aligned with Next.js version

Added New Files

  1. LICENSE.md - GNU General Public License v3
  2. SECURITY.md - Security vulnerability reporting policy
  3. CODEOWNERS - GitHub code ownership definitions for review assignments

Code Cleanup

Removed Debug Logging

  • packages/shared/ui/src/utils/Analytics.ts - Removed debug console.log
  • packages/app/block-explorer/server/src/services/elastic-search/queries/transaction-queries.ts - Removed debug console.log
  • packages/app/liquidity/src/services/liquidity-miner.contract.ts - Removed 8 debug console.log statements

Improved Logging Levels

  • packages/app/uniswap/src/libs/minting-position/providers.ts - Changed console.log to appropriate levels (console.info, console.warn, console.error)
  • packages/app/uniswap/src/libs/minting-position/positions.ts - Changed console.log to console.warn
  • packages/app/block-explorer/ui/src/pages/index.tsx - Changed console.log to console.info

Comment Cleanup

  • packages/shared/core/src/utils/chainGen.ts - Cleaned up inappropriate comment ("Dirty hack" → professional comment)

Testing

  • yarn install - Dependencies installed successfully
  • yarn npm audit --all - No security vulnerabilities
  • yarn prettier:fix - Code formatted
  • yarn lint - No errors (only pre-existing warnings)
  • yarn abe-server build - Builds successfully
  • yarn abe-indexer build - Builds successfully
  • yarn abe-balances build - Builds successfully
  • yarn abe-ui build - Builds successfully

@ivan-cholakov ivan-cholakov requested review from a team and nahuseyoum December 4, 2025 11:51
Copy link
Contributor

@nahuseyoum nahuseyoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few package version upgrades, can we make sure this still works please?

@nahuseyoum nahuseyoum self-requested a review December 17, 2025 11:25
@nahuseyoum nahuseyoum merged commit 1e5e870 into main Dec 17, 2025
5 of 8 checks passed
@nahuseyoum nahuseyoum deleted the SYS-4780-opensourcing-block-explorer branch December 17, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants