fix: resolve git authors to GitHub usernames in release notes#3
Merged
machado144 merged 1 commit intomainfrom Mar 8, 2026
Merged
fix: resolve git authors to GitHub usernames in release notes#3machado144 merged 1 commit intomainfrom
machado144 merged 1 commit intomainfrom
Conversation
✅ StructLint Validation
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Core Changes
- Added
AuthorEmailfield to theDetailedCommitstruct to store the author's email address. - Enhanced
GitService.GetCommitDetailsto fetch the author's email and, if it's a GitHub noreply email, convert theAuthorfield to a@usernameformat. - Modified
PromptService.GenerateGitFallbackNotesto render@usernameauthors as clickable GitHub profile links in the generated release notes.
Verdict
Approve: The changes correctly implement the feature to resolve GitHub usernames from commit emails and format them as links in release notes. The code is clear, functional, and introduces no regressions or critical issues.
Code review performed by GEMINI - gemini-2.5-flash.
machado144
added a commit
that referenced
this pull request
Mar 8, 2026
## Summary - Extract GitHub usernames from noreply email addresses in git commits - Format contributors as @username links in release notes - Works for both AI-generated and git fallback release notes ## Test plan - [ ] Verify `go test ./...` passes - [ ] Trigger a release and check contributors section shows @username links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go test ./...passes