ci: add self-review workflow using reviewforge#2
Conversation
Adds automated PR review using AxeForging/reviewforge with Gemini AI to provide code review feedback on pull requests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- Added a new GitHub Actions workflow (
review.yml) to automate pull request reviews. - The workflow utilizes the
AxeForging/reviewforgeaction, configured with Gemini 2.5 Flash, to provide AI-powered code reviews. - It triggers on
opened,synchronize, andreopenedpull request events targeting themainbranch.
Verdict
Approve: The new workflow is correctly configured and introduces a valuable automation without any critical issues, security vulnerabilities, or breaking changes.
Code review performed by GEMINI - gemini-2.5-flash.
The banner.png in doc/ was causing self-validation to fail because: - Only docs/** was allowed, not doc/** - Image file extensions (png, jpg, svg) were not in allowed patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- A new GitHub Actions workflow (
.github/workflows/review.yml) has been added to enable automated PR self-reviews usingAxeForging/reviewforgewith the Gemini 2.5 Flash model. - The
.structlint.yamlconfiguration has been updated to allow adoc/directory and common image file types (.png,.jpg,.svg) within the project structure.
Verdict
Approve - The changes introduce a useful self-review workflow and update the project's structural linting rules appropriately.
Code review performed by GEMINI - gemini-2.5-flash.
- Add action.yml composite action that downloads pre-built binary and runs validation (no Go setup required for consumers) - Add reusable workflow (.github/workflows/structlint.yml) for org-wide standardized validation via workflow_call - Update README with GitHub Action, reusable workflow, and input docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- Introduced a new GitHub Actions workflow (
.github/workflows/review.yml) to enable automated self-reviews on pull requests usingAxeForging/reviewforge. - Added a reusable GitHub Actions workflow (
.github/workflows/structlint.yml) forstructlintitself, allowing other repositories to easily integrate and validate their structure, with an option to upload a JSON report as an artifact. - Updated the project's
.structlint.yamlconfiguration to permit adoc/directory and common image file types (.png,.jpg,.svg) within the project structure.
Verdict
Approve: The changes are well-implemented, functional, and introduce valuable CI/CD capabilities without any apparent issues.
Code review performed by GEMINI - gemini-2.5-flash.
- Action now generates GitHub Actions Job Summary with validation results - Add comment-on-pr input to post/update results as a PR comment - Comments are upserted (updated on push, not duplicated) - Add validate.yml workflow for self-testing the action on PRs - Update reusable workflow with comment-on-pr support - Update README with PR comment documentation and examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- New GitHub Actions workflows (
review.yml,structlint.yml,validate.yml) have been added to automate self-review and structural validation of the repository. - The
structlintGitHub Action (action.yml) has been implemented to download thestructlintbinary, execute validation, generate a job summary, and post/update PR comments with validation results. - The
.structlint.yamlconfiguration has been updated to includedoc/**in allowed directory paths and*.png,*.jpg,*.svgin allowed file naming patterns, accommodating documentation and image assets.
Verdict
Approve: The changes introduce valuable CI/CD automation and configuration updates without introducing any critical bugs, security vulnerabilities, or breaking changes.
Code review performed by GEMINI - gemini-2.5-flash.
- Use `uses: ./` in validate.yml so the action works before merging to main (standard pattern for self-testing GitHub Actions) - Fix markdown heredoc indentation that would render as code blocks - Remove dead code block for json-output arg Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ StructLint Validation
|
There was a problem hiding this comment.
Core Changes
- Introduces a new GitHub Action (
action.yml) forstructlintto validate project structure and file naming patterns. - Adds a reusable workflow (
.github/workflows/structlint.yml) for easy integration ofstructlintacross repositories. - Configures a self-review workflow (
.github/workflows/review.yml) usingAxeForging/reviewforgeto automate PR reviews. - Updates the project's
.structlint.yamlto allowdoc/directory and common image file types (.png,.jpg,.svg).
Verdict
Approve: The changes are well-implemented, functional, and enhance the project's CI/CD capabilities without introducing any apparent issues.
Code review performed by GEMINI - gemini-2.5-flash.
The binary and tarball were downloaded into the workspace directory, causing structlint to flag them as violations. Moving to /tmp keeps them out of the scan path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- Introduced a new GitHub Actions workflow (
.github/workflows/review.yml) to enable automated PR reviews usingAxeForging/reviewforgewith Gemini 2.5 Flash. - Added a reusable GitHub Actions workflow (
.github/workflows/structlint.yml) forstructlintvalidation, allowing other repositories to easily integrate it. - Updated the project's own
structlintconfiguration (.structlint.yaml) to includedoc/**in allowed paths and image file extensions (.png,.jpg,.svg) in allowed file naming patterns. - Implemented a new composite GitHub Action (
action.yml) forstructlintthat handles downloading the tool, running validation, generating a job summary, and posting/updating PR comments with detailed violation reports.
Concerns
None.
Verdict
Approve: The changes are well-implemented, introduce new functionality, and adhere to best practices for GitHub Actions. No critical issues or bugs were identified.
Code review performed by GEMINI - gemini-2.5-flash.
The jq query was producing a separate header per example instead of listing all examples under one grouped header. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Core Changes
- Introduced a new GitHub Actions workflow (
review.yml) for automated PR self-reviews usingAxeForging/reviewforge. - Added a reusable GitHub Actions workflow (
structlint.yml) to standardizestructlintvalidation across repositories. - Updated the project's own
structlintconfiguration (.structlint.yaml) to allowdoc/directory and common image file types. - Enhanced the
structlintcomposite action (action.yml) to include PR commenting functionality and improved summary generation.
Verdict
Approve: The changes introduce new CI/CD capabilities and update configuration without introducing any critical bugs, security vulnerabilities, or breaking changes. The implementation of the GitHub Actions is robust.
Code review performed by GEMINI - gemini-2.5-flash.
* ci: add self-review workflow using reviewforge Adds automated PR review using AxeForging/reviewforge with Gemini AI to provide code review feedback on pull requests. * fix: allow doc/ directory and image files in structlint config The banner.png in doc/ was causing self-validation to fail because: - Only docs/** was allowed, not doc/** - Image file extensions (png, jpg, svg) were not in allowed patterns * feat: add GitHub Action and reusable workflow for structlint - Add action.yml composite action that downloads pre-built binary and runs validation (no Go setup required for consumers) - Add reusable workflow (.github/workflows/structlint.yml) for org-wide standardized validation via workflow_call - Update README with GitHub Action, reusable workflow, and input docs * feat: add PR comment and job summary support to structlint action - Action now generates GitHub Actions Job Summary with validation results - Add comment-on-pr input to post/update results as a PR comment - Comments are upserted (updated on push, not duplicated) - Add validate.yml workflow for self-testing the action on PRs - Update reusable workflow with comment-on-pr support - Update README with PR comment documentation and examples * fix: use local action reference and fix markdown formatting - Use `uses: ./` in validate.yml so the action works before merging to main (standard pattern for self-testing GitHub Actions) - Fix markdown heredoc indentation that would render as code blocks - Remove dead code block for json-output arg * fix: download structlint binary to /tmp to avoid self-scan The binary and tarball were downloaded into the workspace directory, causing structlint to flag them as violations. Moving to /tmp keeps them out of the scan path. * fix: group violation examples under single header in PR comment The jq query was producing a separate header per example instead of listing all examples under one grouped header. ---------
Summary
Test plan
Generated with Claude Code