fix: auto-detect SSH key instead of hardcoding id_rsa#4
Merged
machado144 merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
- Try id_ed25519, id_ecdsa, id_rsa in order - Add --ssh-key flag to override with a custom path - Add unit tests for detection, override, and isSSH - Add SSH key docs section to README
✅ StructLint Validation
|
There was a problem hiding this comment.
Core Changes
- Introduced a new
--ssh-keyflag forcloneandgeneratecommands, allowing users to specify a custom SSH private key path. - Enhanced the
GitClonerservice to auto-detect SSH keys in a prioritized order:id_ed25519,id_ecdsa, thenid_rsawithin the~/.sshdirectory, falling back to the specified flag if provided. - Added comprehensive unit tests for the new SSH key detection and setting logic.
Concerns
There are no critical concerns regarding security, performance, or logic flaws.
Verdict
Approve: The changes are well-implemented, thoroughly tested, and address a valuable feature request without introducing any regressions or critical issues.
Code review performed by GEMINI - gemini-2.5-flash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_ed25519→id_ecdsa→id_rsa--ssh-keyflag for custom key paths oncloneandgeneratecommandsisSSHWhat changed
services/cloner.go—getSSHKeyPath()now scans for available keys instead of hardcodingid_rsaservices/cloner_test.go— new test file with 7 test casesflags.go— new--ssh-keyflagmain.go— wire flag tocloneandgeneratecommandsactions/clone.go/actions/generate.go— read flag and pass to clonerREADME.md— expandable SSH key docsTest plan
go test ./services/ -run "TestGetSSHKeyPath|TestSetSSHKeyPath|TestIsSSH" -v