Conversation
Collaborator
0xJem
commented
Mar 4, 2025
0xJem
commented
- Removes Baseline from dependencies and disables contracts, to that third-parties can build the repository (as the Baseline repo is not public yet)
- Remove the need to generate test salts by generating salts on demand
Oighty
approved these changes
Mar 5, 2025
Contributor
Oighty
left a comment
Oighty
left a comment
There was a problem hiding this comment.
Removing makes sense to make it easier to import. If there are to use in the future, maybe just move to a new branch and delete from main vs commenting out the files.
Collaborator
Author
I have it active in a local branch (which I will push). If you think deleting from main is better (given the branch), I'll do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.