Ensure reconnects to Platform due to deployments are less noisy #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client logs on every disconnect, even if the reconnect immediately after succeeds. This makes deployments and unstable internet very noisy for our customers. This PR brings an update to the logging, so the user, after initial connection, is only notified of loss of connection and re-attaining at the tenth retry, which means the application has not been connected for 10 seconds. Additionally, I updated the poms and workflows for the axon-4 branch, to continue bugfixes here for AF4. After merge I will port the fix to AF5.
CodeDrivenMitch
requested review from
MartinPfeffer,
alex-w0,
corradom and
stefanmirkovic
and removed request for
a team
stefanmirkovic
approved these changes
Dec 3, 2025
Contributor
stefanmirkovic
left a comment
stefanmirkovic
left a comment
There was a problem hiding this comment.
LGTM. Maybe we could rename everything, including the file names. For example: add-to-platform-project.yml, platform-framework-client-api/, platform-framework-client/, AxoniqPlatformRSocketClient …
Collaborator
Author
|
@stefanmirkovic I have considered renaming everything, but I decided not to. For AF5, we could, als this is a breaking change anyhow, but for AF4 and a patch release, this would break for anyone not using Spring Boot, as they configure their application by calling our classes directly. So we can't rename package names, class names, or modules. We can only update logging where possible. And, AF4 will slowly dwindle to end of life anyway, I don't expect many patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client logs on every disconnect, even if the reconnect immediately after succeeds. This makes deployments and unstable internet very noisy for our customers.
This PR brings an update to the logging, so the user, after initial connection, is only notified of loss of connection and re-attaining at the tenth retry, which means the application has not been connected for 10 seconds.
Additionally, I updated the poms and workflows for the axon-4 branch, to continue bugfixes here for AF4. After merge I will port the fix to AF5.