Making edits of previously suggested changes to C# code of the same sample#15
Making edits of previously suggested changes to C# code of the same sample#15sephilli wants to merge 2 commits intoAzure-Samples:mainfrom
Conversation
| 2. Run app locally : `mvn spring-boot:run` | ||
|
|
||
| 3. Use postman or any debugging tool and open url - http://localhost:8080 | ||
| 3. Use [Postman](https://www.postman.com/) or any debugging tool and open url - http://localhost:8080 |
There was a problem hiding this comment.
@ravithanneeru - I just went through this as well.
I think that advising to 'open url - http://localhost:8080' is insufficient instructions.
Firstly, that just returns a 404 as there is no default route.
Secondly, all of the controller endpoints require a parameter - e.g. serverCallId in .....
@GetMapping("/startRecording")
public StartCallRecordingResult startRecording(String serverCallId)
I tried a few different ways to reference serverCallId, but since it is not directly stated here, I wasn't sure how. When I went to reference Spring Boot, it seems that serverCallId would need to be specified in the GetMapping via something like @GetMapping("/startRecording/{serverCallId}")
I fixed similar things to what I suggested and what was fixed in the C# quickstart, but can you please continue this based on my comments above?
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information