Skip to content

Fix mem leak in event listeners#278

Open
enricohuang wants to merge 1 commit intoAzure-Samples:mainfrom
enricohuang:patch-9
Open

Fix mem leak in event listeners#278
enricohuang wants to merge 1 commit intoAzure-Samples:mainfrom
enricohuang:patch-9

Conversation

@enricohuang
Copy link
Contributor

Purpose

  • Fix mem leak due to some event listeners not being removed after call is ended. (events in the device manager layer)
  • event listeners in the call context or call features will be removed automatically when the call is ended, so we don't need to unregister them.

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants