Open
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR implements a bug fix by replacing the use of the markdown_rules constant with json_rules to format business rules.
- Importing json_rules instead of markdown_rules
- Formatting the query using json_rules
Reviewed Changes
| File | Description |
|---|---|
| templates/natural_language_to_SQL/src/steps/business_rules_step.py | Replaces markdown_rules with json_rules for formatting the business rules |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
templates/natural_language_to_SQL/src/steps/business_rules_step.py:17
- The change from markdown_rules to json_rules should be verified to ensure that the new json_rules constant supports the expected formatting arguments and produces the required output format.
from src.constants.data_model import json_rules
Contributor
There was a problem hiding this comment.
PR Overview
This PR addresses a bug fix in the business rules step by replacing the incorrect markdown_rules constant with the correct json_rules constant.
- Updated the import from markdown_rules to json_rules in business_rules_step.py.
- Modified the usage of the formatting method to use json_rules instead of markdown_rules.
Reviewed Changes
| File | Description |
|---|---|
| templates/natural_language_to_SQL/src/steps/business_rules_step.py | Replaced markdown_rules with json_rules to ensure proper formatting of business rules query |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
templates/natural_language_to_SQL/src/steps/business_rules_step.py:17
- Verify that the json_rules constant provides the expected format for the business rules process and that corresponding tests have been updated to reflect this change.
from src.constants.data_model import json_rules
templates/natural_language_to_SQL/src/steps/business_rules_step.py:27
- Ensure that using json_rules.format aligns with the requirements of business_rules_prompt and that no unintended formatting issues arise due to the change from markdown_rules.
rules_with_query = json_rules.format(question=data.user_query)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information