Open
Conversation
d07e3d1 to
a047276
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds "Snapshot Reference" support to the Azure App Configuration Go provider. Snapshot references allow a key-value setting stored in App Configuration to point to a named snapshot — when loaded, the settings from that snapshot are merged into the configuration. The implementation refactors the existing snapshot loading into a shared helper function, adds content-type detection for snapshot references, and emits a tracing tag when they are used.
Changes:
- Extracts snapshot loading into a reusable
loadSnapshotSettingsfunction and addssnapshotSettingsLoaderfunction type to support snapshot reference resolution with dependency injection. - Adds detection of
snapshotReferenceContentTypeinloadKeyValues, collects snapshot references, and resolves them via the newloadSettingsFromSnapshotRefsmethod. - Adds
UseSnapshotReferencetracing option andSnapshotReferenceTagcorrelation context tag.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
azureappconfiguration/azureappconfiguration.go |
Core implementation: detection of snapshot reference content type, loadSettingsFromSnapshotRefs, and parseSnapshotReference |
azureappconfiguration/settings_client.go |
Extracts snapshot loading into loadSnapshotSettings helper; adds snapshotSettingsLoader type |
azureappconfiguration/internal/tracing/tracing.go |
Adds SnapshotReferenceTag and UseSnapshotReference option to correlation context header |
azureappconfiguration/constants.go |
Adds snapshotReferenceContentType constant |
azureappconfiguration/options.go |
Minor whitespace fix |
azureappconfiguration/snapshot_test.go |
Adds unit tests for parseSnapshotReference and loadSettingsFromSnapshotRefs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref