-
Notifications
You must be signed in to change notification settings - Fork 96
fix(designer): correct for-each concurrency message to state parallel default #8720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o parallel Co-authored-by: takyyon <11722204+takyyon@users.noreply.github.com>
|
@copilot PR title and description needs to follow proper validation and format. Look at other open PRs as an example |
Updated the PR title to follow conventional commits format: The title now matches the required pattern from pr-title-checker-config.json: |
|
@copilot Description should follow a proper template as welll |
The PR description follows the template from
The format matches other open PRs like #8724 (fix type) which uses the same template structure. All sections are present with appropriate content for this text-only change. |
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Reword for clarity (see recommendation) | |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Matches label (risk:low) |
| What & Why | ✅ | Consider referencing string id (RvT4mt) |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | Manual testing OK; optional localization smoke test |
| Contributors | Consider adding credits if any | |
| Screenshots/Videos | Optional: add screenshot of updated UI |
Final message:
This PR largely follows the required template and is appropriate to merge as a low-risk change. Please consider updating the PR title to be a bit clearer and optionally mention the string id in the What & Why. Also, remove the needs-pr-update label once you've made any tiny recommended edits (or add a brief note explaining why the label remains).
Suggested title to replace current one:
fix(designer): update For-each concurrency message to indicate loops run in parallel by default
If you update the title (or add the string id to the What & Why), re-run CI and then remove the needs-pr-update label. Thanks for the tidy, minimal change — this looks ready to merge after the small polish above.
Last updated: Fri, 23 Jan 2026 17:08:09 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Fixes the for-each concurrency control helper text to correctly state that for-each loops run in parallel by default (and removes an unintended trailing backtick).
Changes:
- Updated the for-each concurrency description string from “sequentially” to “in parallel” in both designer implementations.
- Updated the English localization entry for
RvT4mtand removed the trailing backtick character.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/designer/src/lib/ui/settings/sections/general.tsx | Corrects the defaultMessage text for the for-each concurrency description. |
| libs/designer-v2/src/lib/ui/settings/sections/general.tsx | Mirrors the same corrected defaultMessage text in designer-v2. |
| Localize/lang/strings.json | Updates the English localized string for RvT4mt to match the corrected behavior/message. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: takyyon <11722204+takyyon@users.noreply.github.com>
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
|
@copilot Look at the comment for PR description not adhering to the template |
Updated the PR description to follow the proper template format from
The previous "Plan" format has been replaced with the standard PR template structure used across the repository. |
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
This change updates the user-facing concurrency control message for For-each loops to correctly state that loops run in parallel by default and clarifies how to make them sequential (set limit to 1). This fixes a misleading message in the designer UI.
Impact of Change
Test Plan
Contributors
Screenshots/Videos