Skip to content

Conversation

@Elaina-Lee
Copy link
Contributor

@Elaina-Lee Elaina-Lee commented Jan 23, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adding chat history summarization to the agent loop

Impact of Change

  • Users: Users can now find and add chat history as an advanced paramter option
  • Developers: Adds two manifest fields (targetMessageCount, thresholdMessageCount) and a new option value summarizationReduction in agent history reduction settings. No breaking API changes expected, but manifests consumers should handle the new values.
  • System: none

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Local standalone

Contributors

Screenshots/Videos

Recording.2026-01-22.103411.mp4

Copilot AI review requested due to automatic review settings January 23, 2026 19:00
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(Designer-v2): Add chat history summarization
  • Issue: None — title is clear, follows conventional format and describes the change.
  • Recommendation: No change required. Optionally you can mention "manifest" to make it explicit that these are manifest/schema additions, e.g. feat(Designer-v2): Add chat history summarization (manifest) — only if you want extra clarity.

Commit Type

  • Properly selected (feature).
  • Note: Only one commit type is selected which is correct.

Risk Level

  • Assessment: The PR is labeled risk:low and the body selects Low. The code diff adds manifest/schema fields and an option value (no runtime or breaking changes observed). Advised risk: risk:low (matches submitter).

What & Why

  • Current: "Adding chat history summarization to the agent loop"
  • Issue: None — succinct and appropriate.
  • Recommendation: If helpful, add one sentence on the expected behavior (e.g., when summarization runs and a brief note on how targetMessageCount / thresholdMessageCount interact). This helps reviewers quickly reason about correctness.

Impact of Change

  • The Impact section is present and correctly lists Users, Developers, and System.
  • Recommendation: Small suggestion to clarify Developer impact: mention that manifest consumers should tolerate unknown fields or new enum values (you already noted this; consider adding an example or version note if applicable).
    • Users: Users can enable an advanced option for chat history summarization.
    • Developers: Update manifest consumers to handle new manifest fields (targetMessageCount, thresholdMessageCount) and new agentHistoryReductionSettings value summarizationReduction.
    • System: No runtime or architecture changes expected.

⚠️ Test Plan

  • Assessment: Manual testing is marked and a local standalone environment is listed.
  • Issue: No unit or E2E tests were added.
  • Recommendation: Because these are manifest/schema changes, consider adding a small unit/regression test asserting the schema contains the new fields and enum option, or an E2E/validation test that ensures these fields behave as expected in the manifest loader. If adding tests isn't practical, expand the Test Plan to explain why manual-only testing is sufficient and add brief repro/validation steps you performed locally (screenshots or a short checklist of what you verified).

⚠️ Contributors

  • Assessment: Empty.
  • Recommendation: Add any contributors (PMs, designers, reviewers) who contributed. If none, it's fine to leave blank, but adding at least a line acknowledging reviewers/PMs is helpful.

Screenshots/Videos

  • Assessment: A link was included in the body.
  • Recommendation: If the link is to an attachment, ensure it renders in the PR; otherwise consider uploading inline screenshots to the PR discussion for easier review.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Low risk is appropriate
What & Why Optionally expand one sentence on behavior
Impact of Change Clarify manifest consumer guidance if desired
Test Plan ⚠️ Add schema/unit tests or expand manual test notes
Contributors ⚠️ List contributors or add a note
Screenshots/Videos Ensure the attachment renders in PR

Final notes:

  • The code diff adds a new agent history reduction option summarizationReduction and adds two manifest integer fields (targetMessageCount, thresholdMessageCount) in both the consumption and standard manifests. These are schema/manifest changes only — low risk.
  • Please consider adding a short unit test or validation test checking the manifest includes the new enum value and fields, or expand the Test Plan with exact manual steps you followed (how you validated visibility, how the UI behaves when the option is selected). This will reduce future regressions.
  • Add contributors if anyone else helped, and verify the screenshot/attachment renders for reviewers.
  • There is a needs-pr-update label currently attached; if you address any of the above suggestions (tests/expanded Test Plan or contributors) remove the label once updated.

Please update the PR body with the small clarifications above if possible, then re-submit. Thank you for the clear PR — nice work keeping the description concise and including the manifest changes in both places.


Last updated: Fri, 23 Jan 2026 20:09:24 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds chat history summarization support to the Agent Loop feature in both Standard and Consumption Logic Apps. The changes enable users to configure a new "Summarization reduction" option for managing agent chat history, with associated parameters for controlling when and how summarization occurs.

Changes:

  • Added new "Summarization reduction" option to the agent history reduction type dropdown
  • Added two conditional integer fields (targetMessageCount and thresholdMessageCount) that appear when summarization reduction is selected
  • Applied changes consistently across both Standard and Consumption manifest configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/agentloop.ts Added summarization reduction dropdown option and two conditional integer fields (targetMessageCount, thresholdMessageCount) with visibility dependencies
libs/logic-apps-shared/src/designer-client-services/lib/consumption/manifests/agentloop.ts Added identical summarization reduction configuration as in standard manifest for consistency

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@Elaina-Lee Elaina-Lee added the risk:low Low risk change with minimal impact label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants