Skip to content

fix: update resourceType field to use subscriptionName instead of subscription#787

Merged
cmendible merged 1 commit intomainfrom
issue-786
Mar 10, 2026
Merged

fix: update resourceType field to use subscriptionName instead of subscription#787
cmendible merged 1 commit intomainfrom
issue-786

Conversation

@cmendible
Copy link
Member

Description

This pull request makes a minor update to the table rendering logic in internal/viewer/static/app.js by renaming the subscription column to subscriptionName for the resourceType dataset. This change ensures consistency in column naming across the application.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #786

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

Copy link
Member Author

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 4af8859 into main Mar 10, 2026
4 checks passed
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.96%. Comparing base (4f69e79) to head (f88f5a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   21.96%   21.96%           
=======================================
  Files          94       94           
  Lines        5987     5987           
=======================================
  Hits         1315     1315           
  Misses       4569     4569           
  Partials      103      103           
Flag Coverage Δ
unittests 21.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web Viewer for Resource Type view does not show the Subscription Name

2 participants