IoT Hub + DPS CSR feature support#1821
Open
timtay-microsoft wants to merge 33 commits intofeature/csrfrom
Open
IoT Hub + DPS CSR feature support#1821timtay-microsoft wants to merge 33 commits intofeature/csrfrom
timtay-microsoft wants to merge 33 commits intofeature/csrfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPS device client changes
IoT hub device client changes
Samples changes
Misc changes
Notable design choices
Below are a few design choices I made that may conflict with implementations of this CSR feature in other languages so far. I singled these out so that it is easier for us to discuss their merits cross-language.
The new IoT hub device client
sendCertificateSigningRequestmethod notifies the user at each stage of the CSR process (CSR accepted, CSR complete and if/when a CSR error is reported by IoT hub)sendCertificateSigningRequestAPI that just returns when signing completes or errors out, though (add it later if users ask?). It just shouldn't be the only way to do signing.The IoT hub SDK allows users to see what request Id is associated with their CSR
Neither the IoT hub nor DPS SDKs added certificate "helper" methods