mgmt, Migrate azure-resourcemanager-cdn to TypeSpec#48177
Draft
weidongxu-microsoft wants to merge 23 commits intoAzure:mainfrom
Draft
mgmt, Migrate azure-resourcemanager-cdn to TypeSpec#48177weidongxu-microsoft wants to merge 23 commits intoAzure:mainfrom
weidongxu-microsoft wants to merge 23 commits intoAzure:mainfrom
Conversation
- Add implementation.models to module-info.java - Add CDN revapi suppressions for expected breaking changes - Regenerated SDK code from TypeSpec Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
the
Mgmt
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
from
cd6a205 to
7ef8fda
Compare
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
2 times, most recently
from
e9ea4bb to
bd54e70
Compare
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
from
bd54e70 to
1e6cd8c
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weidongxu-microsoft
changed the title
Comment on lines
-19
to
24
| public final class CacheExpirationActionParameters implements JsonSerializable<CacheExpirationActionParameters> { | ||
| public final class CacheExpirationActionParameters extends DeliveryRuleActionParameters { | ||
| /* | ||
| * The typeName property. | ||
| */ | ||
| private String typeName = "DeliveryRuleCacheExpirationActionParameters"; | ||
| private DeliveryRuleActionParametersType typeName | ||
| = DeliveryRuleActionParametersType.DELIVERY_RULE_CACHE_EXPIRATION_ACTION_PARAMETERS; | ||
|
|
Member
Author
There was a problem hiding this comment.
Breaking changes are mostly on these classes.
However, I am a bit puzzled why it was not a polymorphic class in 2024-02-01
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/Cdn/stable/2024-02-01/cdn.json#L5245-L5256
<-- this uses "allOf DeliveryRuleActionParameters"
And this be the base
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/Cdn/stable/2024-02-01/cdn.json#L3197-L3223
Seems either m4 or emitter spread the base into it? As there is typeName property, which comes from base.
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
from
f05933f to
2eca843
Compare
XiaofeiCao
approved these changes
Mar 3, 2026
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
from
f87a5b6 to
95cde2d
Compare
weidongxu-microsoft
force-pushed
the
migrate-cdn
branch
from
95cde2d to
d2aa043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate azure-resourcemanager-cdn from autorest to TypeSpec emitter. Spec PR: Azure/azure-rest-api-specs#40902
TODO: major task to switch to AFD based profile and endpoint and rule -- letting agent write it
481ef5f