Skip to content

Add a full url to negotiate response #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zackliu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a full url to negotiate response #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/webpubsub-socketio-extension/review/web-pubsub-socket.io.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export interface NegotiateResponse {
endpoint: string;
path: string;
token: string;
url: string;
}

// @public
Expand Down
1 change: 1 addition & 0 deletions sdk/webpubsub-socketio-extension/src/SIO/components/negotiate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export function negotiate(
endpoint: url.origin,
path: url.pathname,
token: tokenResponse.token,
url: tokenResponse.baseUrl,
};
writeResponse(res, 200, message);
debug("negotiate, finished");
Expand Down
4 changes: 4 additions & 0 deletions sdk/webpubsub-socketio-extension/src/common/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export interface NegotiateResponse {
* The token used to connect to Web PubSub for Socket.IO.
*/
token: string;
/**
* The url of Web PubSub for Socket.IO. The format is `https://<endpoint>/<path>`.
*/
url: string;
}

/**
Expand Down