Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new azslurm show_topology command to visualize block topology configurations in either table or JSON format. The command allows users to view the current block topology configuration parsed from a topology file.
- Adds
show_topologyCLI command with table and JSON output formats - Moves the
output_block_nodelistfunction fromtopology.pytoutil.pyfor reuse - Updates documentation with usage examples and command description
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azure-slurm/slurmcc/util.py | Adds output_block_nodelist function and required imports for parsing topology files |
| azure-slurm/slurmcc/topology.py | Removes output_block_nodelist function (moved to util.py) |
| azure-slurm/slurmcc/cli.py | Adds show_topology_parser and show_topology methods to implement the new CLI command |
| README.md | Updates documentation with show_topology command usage and examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f69c7b8 to
0aa36f0
Compare
0aa36f0 to
83d4e56
Compare
Collaborator
Author
|
Moving output_block_nodelist to util.py may affect scale_m1 script since it is importing that function from topology.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
azslurm show_topologycommand to visualize block topology configuration as table or jsonTo view block topology configuration in table format:
To view block topology configuration in json format: