You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR should include-- an exporter project-- thats independently buildable as the first step-- meaning someone should be able to just do python build . to build the project which should generate the tar.gz file and a pip install of the tar,gz file should result in systemd service being functional. That is the meaning of correct packaging. Full integration is not necessary for the pupose of this PR and that is just resulting in bad build practises.. So therefore-- for the purpose of this PR-- only diff should be in exporter project.
This PR should include-- an exporter project-- thats independently buildable as the first step-- meaning someone should be able to just do python build . to build the project which should generate the tar.gz file and a pip install of the tar,gz file should result in systemd service being functional. That is the meaning of correct packaging. Full integration is not necessary for the pupose of this PR and that is just resulting in bad build practises.. So therefore-- for the purpose of this PR-- only diff should be in exporter project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.