-
Notifications
You must be signed in to change notification settings - Fork 299
Add server-level description field to MCP runtime configuration #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>
Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>
…sponse object creation Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>
Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a server-level description field to the MCP runtime configuration that enables DAB to expose semantic guidance to MCP clients via the initialize response's instructions field.
- Adds optional
descriptionparameter to MCP runtime configuration model - Implements CLI support for configuring the description via
dab configure --runtime.mcp.description - Wires the description value into the MCP initialize response as the
instructionsfield
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Config/ObjectModel/McpRuntimeOptions.cs |
Adds Description property to store the server-level description |
src/Config/Converters/McpRuntimeOptionsConverterFactory.cs |
Implements serialization/deserialization for the description field |
src/Cli/ConfigGenerator.cs |
Updates configuration generator to handle description parameter and adds it to the MCP configuration check |
src/Cli/Commands/ConfigureOptions.cs |
Adds CLI option --runtime.mcp.description for setting the description |
src/Cli.Tests/ConfigureOptionsTests.cs |
Adds unit tests for setting and updating MCP description via CLI |
src/Azure.DataApiBuilder.Mcp/Core/McpStdioServer.cs |
Retrieves description from runtime config and includes it as instructions in initialize response |
Comments suppressed due to low confidence (1)
src/Azure.DataApiBuilder.Mcp/Core/McpStdioServer.cs:209
- The serialization uses JsonSerializer.Serialize without specifying JsonSerializerOptions. By default, System.Text.Json includes null properties in the output, which means the instructions field will be present with a null value when the description is not configured. To omit null properties from the response, you should configure JsonSerializerOptions with DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull. This is important for MCP protocol compliance where optional fields should be omitted rather than included with null values.
string json = JsonSerializer.Serialize(response);
Console.Out.WriteLine(json);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ge cases Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
…ass RuntimeConfig Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
…rver configuration Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
@copilot, can you look at the failures in this pipeline and fix the errors in the build? https://dev.azure.com/sqldab/Data%20API%20builder%20Dependency%20Packages/_build/results?buildId=16109&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=006e6f7c-8314-5e02-a3df-483f3a1f4cfa |
Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
Fixed the build errors. The issue was using nullable reference type annotations ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Why make this change?
MCP clients and agents require high-level behavioral context for servers via the
initializeresponse'sinstructionsfield. DAB previously had no mechanism to surface this configurable semantic guidance.What is this change?
Added optional
descriptionfield to MCP runtime configuration that populates the MCP protocol'sinstructionsfield:Configuration model
McpRuntimeOptionsnow acceptsdescriptionparameterMcpRuntimeOptionsConverterhandles serialization/deserializationCLI integration
dab configure --runtime.mcp.description "text"command supportMCP server response
HandleInitialize()retrieves description fromRuntimeConfig.Runtime.Mcp.Descriptionand conditionally includesinstructionsin initialize response when non-emptyobjecttype instead ofvarfor better type clarityTesting
McpRuntimeOptionsSerializationTestscovering:TestAddDescriptionToMcpSettingsand renamedTestUpdateDescriptionForMcpSettingstoTestConfigureDescriptionForMcpSettingsExample configuration:
{ "runtime": { "mcp": { "enabled": true, "description": "This MCP provides access to the Products database..." } } }How was this tested?
Sample Request(s)
CLI usage:
dab configure --runtime.mcp.description "This MCP provides access to the Products database and should be used to answer product-related or inventory-related questions from the user."MCP initialize response (when description configured - Stdio Server):
{ "jsonrpc": "2.0", "id": 1, "result": { "protocolVersion": "2024-11-05", "capabilities": { ... }, "serverInfo": { "name": "SQL MCP Server", "version": "1.0.0" }, "instructions": "This MCP provides access to the Products database..." } }Note: The HTTP server currently only updates the server name to "SQL MCP Server". Instructions support will be added when the ModelContextProtocol.AspNetCore library adds support for this field in future versions.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.