Open
Conversation
jrdouceur
requested review from
RLeclair,
avishekpant,
cartertinney,
clecompt-msft,
maximsemenov80,
olivakar,
timtay-microsoft and
vaavva
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new WoT Thing Model (“Counter”) under the engineering test schema samples and checks in the corresponding generated .NET “TestThing” sample artifacts produced by the v2 protocol compiler (codegen2), including schemas, serializer/converter utilities, and generated command/telemetry envoys.
Changes:
- Introduce
Counter.TM.jsonThing Model sample for telemetry + RPC actions. - Add a new
dotnet/samples/Protocol/TestThingsample project containing generated C# client/service code for Counter actions/events. - Add generated JSON Schemas for the Counter action inputs/outputs and event collection.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/test/schema-samples/Counter.TM.json | New Counter Thing Model sample (actions + event telemetry topics). |
| dotnet/samples/Protocol/TestThing/TestThing.csproj | New .NET sample project to compile the generated Counter types/envoys. |
| dotnet/samples/Protocol/TestThing/gen.sh | Script to regenerate the sample via codegen2 ProtocolCompiler. |
| dotnet/samples/Protocol/TestThing/schemas/ReadCounterOutputArguments.schema.json | Generated JSON schema for readCounter output. |
| dotnet/samples/Protocol/TestThing/schemas/IncrementInputArguments.schema.json | Generated JSON schema for increment input. |
| dotnet/samples/Protocol/TestThing/schemas/IncrementOutputArguments.schema.json | Generated JSON schema for increment output. |
| dotnet/samples/Protocol/TestThing/schemas/EventCollection.schema.json | Generated JSON schema for aggregated event payload. |
| dotnet/samples/Protocol/TestThing/Utf8JsonSerializer.cs | Generated payload serializer used by command/telemetry envoys. |
| dotnet/samples/Protocol/TestThing/BytesJsonConverter.cs | Generated JSON converter utility (base64 bytes). |
| dotnet/samples/Protocol/TestThing/DateJsonConverter.cs | Generated JSON converter utility (DateOnly). |
| dotnet/samples/Protocol/TestThing/TimeJsonConverter.cs | Generated JSON converter utility (TimeOnly). |
| dotnet/samples/Protocol/TestThing/DurationJsonConverter.cs | Generated JSON converter utility (TimeSpan duration). |
| dotnet/samples/Protocol/TestThing/UuidJsonConverter.cs | Generated JSON converter utility (Guid/UUID). |
| dotnet/samples/Protocol/TestThing/DecimalString.cs | Generated decimal-string wrapper type used by serializers. |
| dotnet/samples/Protocol/TestThing/DecimalJsonConverter.cs | Generated converter for DecimalString. |
| dotnet/samples/Protocol/TestThing/EmptyJson.cs | Generated empty payload marker type for no-arg commands. |
| dotnet/samples/Protocol/TestThing/ValueExtractor.cs | Generated helper extensions for nullable extraction. |
| dotnet/samples/Protocol/TestThing/PropertyTopicAttribute.cs | Generated attribute used by property-related codegen patterns. |
| dotnet/samples/Protocol/TestThing/Counter/Counter.g.cs | Generated Counter client/service wrapper aggregating actions + telemetry. |
| dotnet/samples/Protocol/TestThing/Counter/EventCollection.g.cs | Generated event payload type for Counter events. |
| dotnet/samples/Protocol/TestThing/Counter/EventCollectionSender.g.cs | Generated telemetry sender envoy for Counter events. |
| dotnet/samples/Protocol/TestThing/Counter/EventCollectionReceiver.g.cs | Generated telemetry receiver envoy for Counter events. |
| dotnet/samples/Protocol/TestThing/Counter/ReadCounterOutputArguments.g.cs | Generated output arguments model for readCounter. |
| dotnet/samples/Protocol/TestThing/Counter/ReadCounterActionInvoker.g.cs | Generated command invoker envoy for readCounter. |
| dotnet/samples/Protocol/TestThing/Counter/ReadCounterActionExecutor.g.cs | Generated command executor envoy for readCounter. |
| dotnet/samples/Protocol/TestThing/Counter/IncrementInputArguments.g.cs | Generated input arguments model for increment. |
| dotnet/samples/Protocol/TestThing/Counter/IncrementOutputArguments.g.cs | Generated output arguments model for increment. |
| dotnet/samples/Protocol/TestThing/Counter/IncrementActionInvoker.g.cs | Generated command invoker envoy for increment. |
| dotnet/samples/Protocol/TestThing/Counter/IncrementActionExecutor.g.cs | Generated command executor envoy for increment. |
| dotnet/samples/Protocol/TestThing/Counter/ResetActionInvoker.g.cs | Generated command invoker envoy for reset. |
| dotnet/samples/Protocol/TestThing/Counter/ResetActionExecutor.g.cs | Generated command executor envoy for reset. |
Member
|
A couple things here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.