[.NET] Update sample connectors' metadata#1260
Open
timtay-microsoft wants to merge 10 commits intomainfrom
Open
[.NET] Update sample connectors' metadata#1260timtay-microsoft wants to merge 10 commits intomainfrom
timtay-microsoft wants to merge 10 commits intomainfrom
Conversation
Also remove some unused fields from the sample kubernetes resources
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET sample connectors to use the newer AIO connector metadata schema and simplifies some sample Kubernetes asset resources by removing unused fields.
Changes:
- Added
connector-metadata.jsonfiles for the SQL and REST polling sample connectors using theaio-connector-metadata-10.0-previewschema. - Updated the Event Driven TCP connector’s metadata file to the new schema format.
- Removed unused
dataSourcefields from sample asset definition YAMLs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/samples/Connectors/SqlConnector/connector-metadata.json | Adds new connector metadata for the SQL sample connector. |
| dotnet/samples/Connectors/SqlConnector/KubernetesResources/sql-server-asset-definition.yaml | Removes an unused/invalid dataSource field from the asset definition. |
| dotnet/samples/Connectors/PollingRestThermostatConnector/connector-metadata.json | Adds new connector metadata for the REST polling thermostat connector. |
| dotnet/samples/Connectors/PollingRestThermostatConnector/KubernetesResources/rest-server-asset1-definition.yaml | Removes an unused/invalid dataSource field from the asset definition. |
| dotnet/samples/Connectors/EventDrivenTcpThermostatConnector/connector-metadata.json | Updates metadata format, but currently does not match the TCP connector sample and appears structurally invalid. |
dotnet/samples/Connectors/PollingRestThermostatConnector/connector-metadata.json
Show resolved
Hide resolved
dotnet/samples/Connectors/PollingRestThermostatConnector/connector-metadata.json
Outdated
Show resolved
Hide resolved
dotnet/samples/Connectors/EventDrivenTcpThermostatConnector/connector-metadata.json
Outdated
Show resolved
Hide resolved
dotnet/samples/Connectors/EventDrivenTcpThermostatConnector/connector-metadata.json
Outdated
Show resolved
Hide resolved
…ctor-metadata.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nnector-metadata.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
maximsemenov80
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove some unused fields from the sample kubernetes resources
The TCP sample had an outdated metadata doc and the TCP + SQL connectors had no metadata doc.
These metadata docs won't actually be published since these connectors aren't published. However, they are here as a reference to those who write connectors.
Also add a check in the gates for validating that these samples' metadata matches the connector metadata schema