Add resilient ib plugin #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippogr
reviewed
Aug 21, 2024
| { | ||
| WARN("NET/IB : Got async event : %s event type: %d deviceid:%d device name:%s", str, event.event_type, d, context->device->name); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
shall we keep the original code and print the device name for all the warnings instead of the resilient enabled ones?
hippogr
reviewed
Aug 21, 2024
| NCCL_PARAM(IbQpsPerConn, "IB_QPS_PER_CONNECTION", 1); | ||
|
|
||
| std::unordered_set<std::string> disabledIbPeer; | ||
| void disableIb(std::string peerAddr) |
Collaborator
hippogr
reviewed
Aug 21, 2024
| } | ||
| } | ||
|
|
||
| bool getIbDisableStatus(std::string peerAddr) |
Collaborator
hippogr
reviewed
Aug 21, 2024
| if (err != cudaSuccess) { | ||
| WARN("%ld is not a valid pointer", rComm->remFifo.elems[slot][id].addr); | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
just curious, if this addr is not a valid pointer, should we break the current loop and throw some errors? Why do we simply log it and continue?
hippogr
reviewed
Aug 21, 2024
| { | ||
| return nRet; | ||
| } | ||
| disableIb(comm->addr); |
Collaborator
There was a problem hiding this comment.
Question here: looks like we will process all of the QPs here and may disable the comm->addr multiple times, why not disable the addr when there is error happening when calling post_recv? Besides, when we will also call ncclIbPostFifo even calling post_recv fails and device is disabled, is this logic as same as the original logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.