Merged
Conversation
…e Otel collector destination
abhipsaMisra
reviewed
Aug 6, 2025
abhipsaMisra
approved these changes
Aug 11, 2025
abhipsaMisra
approved these changes
Aug 11, 2025
byronjinmsft
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a target_filter attribute for LogExportTargets struct. This will help users attach a target to their logs and make sure only a subset of the logs are going to be exported to the Otel collector
Unrelated to the main feature, there is a make test failure in mocks.rs. The [clippy::result_large_err] lint warns when the [Err] variant of a Result<T, E> type is very large (in this case, 176 bytes). This can be problematic because:
Stack allocation/deallocation, Moving/copying the Result around, etc
Why is tonic::Status Large?
The tonic::Status type is large because it contains:
Error code, Error message (String), Error details, Metadata, Source information. All of this adds up to 176+ bytes.
But since this code is:
The #[allow(clippy::result_large_err)] is reasonable here because: