Skip to content

Releases/v2 set isLinux param for publish profile #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraksh1 merged 3 commits into from
Jul 21, 2025
Merged

Releases/v2 set isLinux param for publish profile #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9def3e7
set resources details for publish profile
kumaraksh1 Jul 21, 2025
59bb7b5
changing log level
kumaraksh1 Jul 21, 2025
66c2bfb
change log level
kumaraksh1 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions lib/ActionInputValidator/ValidatorFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,37 @@
"use strict";
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
var desc = Object.getOwnPropertyDescriptor(m, k);
if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
desc = { enumerable: true, get: function() { return m[k]; } };
}
Object.defineProperty(o, k2, desc);
}) : (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
o[k2] = m[k];
}));
var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
Object.defineProperty(o, "default", { enumerable: true, value: v });
}) : function(o, v) {
o["default"] = v;
});
var __importStar = (this && this.__importStar) || (function () {
var ownKeys = function(o) {
ownKeys = Object.getOwnPropertyNames || function (o) {
var ar = [];
for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
return ar;
};
return ownKeys(o);
};
return function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
__setModuleDefault(result, mod);
return result;
};
})();
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
Expand All @@ -13,6 +46,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
};
Object.defineProperty(exports, "__esModule", { value: true });
exports.ValidatorFactory = void 0;
const core = __importStar(require("@actions/core"));
const actionparameters_1 = require("../actionparameters");
const AzureResourceFilterUtility_1 = require("azure-actions-appservice-rest/Utilities/AzureResourceFilterUtility");
const BaseWebAppDeploymentProvider_1 = require("../DeploymentProvider/Providers/BaseWebAppDeploymentProvider");
Expand All @@ -35,6 +69,12 @@ class ValidatorFactory {
return new PublishProfileContainerWebAppValidator_1.PublishProfileContainerWebAppValidator();
}
else {
try {
yield this.setResourceDetails(actionParams);
}
catch (error) {
core.warning(`Failed to set resource details: ${error.message}`);
}
return new PublishProfileWebAppValidator_1.PublishProfileWebAppValidator();
}
}
Expand Down
18 changes: 9 additions & 9 deletions lib/DeploymentProvider/Providers/WebAppDeploymentProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,24 +123,24 @@ class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider_1.BaseWebApp
return __awaiter(this, void 0, void 0, function* () {
// Ignore if the app is not a Linux app or if release.zip does not exist
if (!this.actionParams.isLinux) {
core.info(`It's not a Linux app, skipping deletion of release.zip`);
core.debug(`It's not a Linux app, skipping deletion of release.zip`);
return;
}
const releaseZipPath = path_1.default.join(webPackage, 'release.zip');
if (!fs_1.default.existsSync(releaseZipPath)) {
core.info(`release.zip does not exist, skipping deletion: ${releaseZipPath}`);
core.debug(`release.zip does not exist, skipping deletion: ${releaseZipPath}`);
return;
}
let isPhpApp = yield this.checkIfTheAppIsPhpApp(webPackage);
// No need to delete release.zip for non-PHP apps
if (!isPhpApp) {
core.info(`Not a PHP app, skipping deletion of release.zip: ${releaseZipPath}`);
core.debug(`Not a PHP app, skipping deletion of release.zip: ${releaseZipPath}`);
return;
}
// Delete release.zip if it exists
try {
yield fs_1.default.promises.unlink(releaseZipPath);
core.info(`Deleted release.zip`);
core.debug(`Deleted release.zip`);
}
catch (error) {
core.debug(`Error while deleting release.zip for Linux PHP app: ${error}`);
Expand All @@ -153,22 +153,22 @@ class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider_1.BaseWebApp
// Check if the webPackage folder contains a composer.json file
const composerFile = 'composer.json';
if (fs_1.default.existsSync(path_1.default.join(webPackage, composerFile))) {
core.info(`Detected PHP app by presence of ${composerFile}`);
core.debug(`Detected PHP app by presence of ${composerFile}`);
return true;
}
// Check if the webPackage folder contains a .php file
core.info(`Checking for .php files in the web package directory: ${webPackage}`);
core.debug(`Checking for .php files in the web package directory: ${webPackage}`);
const hasPhpFiles = fs_1.default.readdirSync(webPackage, { withFileTypes: true, recursive: true }).some(file => file.isFile() && file.name.endsWith('.php'));
if (hasPhpFiles) {
core.info(`Detected PHP app by presence of .php files`);
core.debug(`Detected PHP app by presence of .php files`);
}
else {
core.info(`No .php files found in the web package directory.`);
core.debug(`No .php files found in the web package directory.`);
}
return hasPhpFiles;
}
catch (error) {
core.info(`Error while checking if the app is PHP: ${error}`);
core.debug(`Error while checking if the app is PHP: ${error}`);
}
return false;
});
Expand Down
6 changes: 6 additions & 0 deletions src/ActionInputValidator/ValidatorFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as core from "@actions/core";
import { ActionParameters, WebAppKind, appKindMap } from "../actionparameters";

import { AzureResourceFilterUtility } from "azure-actions-appservice-rest/Utilities/AzureResourceFilterUtility";
Expand All @@ -22,6 +23,11 @@ export class ValidatorFactory {
return new PublishProfileContainerWebAppValidator();
}
else {
try {
await this.setResourceDetails(actionParams);
} catch (error) {
core.warning(`Failed to set resource details: ${error.message}`);
}
return new PublishProfileWebAppValidator();
}
}
Expand Down
19 changes: 9 additions & 10 deletions src/DeploymentProvider/Providers/WebAppDeploymentProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { addAnnotation } from 'azure-actions-appservice-rest/Utilities/Annotatio

import fs from 'fs';
import path from 'path';
import { dir } from 'console';

export class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider {

Expand Down Expand Up @@ -90,29 +89,29 @@ export class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider {

// Ignore if the app is not a Linux app or if release.zip does not exist
if (!this.actionParams.isLinux) {
core.info(`It's not a Linux app, skipping deletion of release.zip`);
core.debug(`It's not a Linux app, skipping deletion of release.zip`);
return;
}

const releaseZipPath = path.join(webPackage, 'release.zip');

if (!fs.existsSync(releaseZipPath)) {
core.info(`release.zip does not exist, skipping deletion: ${releaseZipPath}`);
core.debug(`release.zip does not exist, skipping deletion: ${releaseZipPath}`);
return;
}

let isPhpApp = await this.checkIfTheAppIsPhpApp(webPackage);

// No need to delete release.zip for non-PHP apps
if (!isPhpApp) {
core.info(`Not a PHP app, skipping deletion of release.zip: ${releaseZipPath}`);
core.debug(`Not a PHP app, skipping deletion of release.zip: ${releaseZipPath}`);
return;
}

// Delete release.zip if it exists
try {
await fs.promises.unlink(releaseZipPath);
core.info(`Deleted release.zip`);
core.debug(`Deleted release.zip`);
} catch (error) {
core.debug(`Error while deleting release.zip for Linux PHP app: ${error}`);
}
Expand All @@ -124,23 +123,23 @@ export class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider {
// Check if the webPackage folder contains a composer.json file
const composerFile = 'composer.json';
if (fs.existsSync(path.join(webPackage, composerFile))) {
core.info(`Detected PHP app by presence of ${composerFile}`);
core.debug(`Detected PHP app by presence of ${composerFile}`);
return true;
}

// Check if the webPackage folder contains a .php file
core.info(`Checking for .php files in the web package directory: ${webPackage}`);
core.debug(`Checking for .php files in the web package directory: ${webPackage}`);
const hasPhpFiles = fs.readdirSync(webPackage, {withFileTypes: true, recursive: true}).some(file => file.isFile() && file.name.endsWith('.php'));

if (hasPhpFiles) {
core.info(`Detected PHP app by presence of .php files`);
core.debug(`Detected PHP app by presence of .php files`);
} else {
core.info(`No .php files found in the web package directory.`);
core.debug(`No .php files found in the web package directory.`);
}

return hasPhpFiles;
} catch (error) {
core.info(`Error while checking if the app is PHP: ${error}`);
core.debug(`Error while checking if the app is PHP: ${error}`);
}

return false;
Expand Down
Loading