Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:

- name: 'Checking out repo code'
uses: actions/checkout@v2
uses: actions/checkout@v6

- name: 'Validate build'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/defaultLabels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- uses: actions/stale@v3
- uses: actions/stale@v10
name: Setting issue as idle
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -24,7 +24,7 @@ jobs:
operations-per-run: 100
exempt-issue-labels: 'backlog'

- uses: actions/stale@v3
- uses: actions/stale@v10
name: Setting PR as idle
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/github_actions_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
id-token: write

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Modify the sample app
run: |
Expand All @@ -29,7 +29,7 @@ jobs:
echo "The placeholder has been replaced with current UTC time: $current_utc_time"

- name: Set up .NET Core
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
dotnet-version: '8.x'

Expand All @@ -40,7 +40,7 @@ jobs:
run: dotnet publish dotnetapp/DOTNET_8_APP.csproj -c Release -o myapp

- name: Upload artifact for deployment job
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: .net-app
path: myapp
Expand All @@ -67,7 +67,7 @@ jobs:
id-token: write

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: modify Node.js App
run: |
Expand All @@ -78,7 +78,7 @@ jobs:
echo "The placeholder has been replaced with current UTC time: $current_utc_time"

- name: Set up Node.js version
uses: actions/setup-node@v3
uses: actions/setup-node@v6
with:
node-version: '18.x'

Expand All @@ -90,7 +90,7 @@ jobs:
npm run test --if-present

- name: Upload artifact for deployment job
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: node-app
path: nodeapp
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr_check_webapp_dotnet_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v6

- uses: actions/checkout@master
with:
Expand All @@ -46,7 +46,7 @@ jobs:
path: 'dotnetsample'

- name: Install Nuget
uses: nuget/setup-nuget@v1
uses: nuget/setup-nuget@v2
with:
nuget-version: ${{ env.NUGET_VERSION}}
- name: NuGet to restore dependencies as well as project-specific tools that are specified in the project file
Expand All @@ -56,12 +56,12 @@ jobs:
nuget restore

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v1.0.2
uses: microsoft/setup-msbuild@v2.0.0

- name: Run MSBuild
run: msbuild .\dotnetsample\SampleWebApplication.sln

- uses: actions/checkout@v2
- uses: actions/checkout@v6
name: Checkout from PR branch
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
docker logout env.CONTAINER_REGISTRY

- name: Login to Azure Container Registry
uses: azure/docker-login@v1
uses: azure/docker-login@v2
with:
login-server: ${{ env.CONTAINER_REGISTRY }}
username: ${{ secrets.WEBDEPLOY_TEST_ACR_USERNAME }}
Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,18 @@ jobs:
- name: 'Checkout Github Action'
uses: actions/checkout@master

- name: Setup Node 10.x
uses: actions/setup-node@v1
- name: Setup Node 24.x
uses: actions/setup-node@v6
with:
node-version: '10.x'
node-version: '24.x'
- name: 'npm install, build, and test'
run: |
npm install
npm run build --if-present
npm run test --if-present

- name: 'Run Azure webapp deploy action using publish profile credentials'
uses: azure/webapps-deploy@v2
uses: azure/webapps-deploy@v3
with:
app-name: node-rn
publish-profile: ${{ secrets.azureWebAppPublishProfile }}
Expand All @@ -111,7 +111,7 @@ jobs:
- name: 'Checkout Github Action'
uses: actions/checkout@master

- uses: azure/docker-login@v1
- uses: azure/docker-login@v2
with:
login-server: contoso.azurecr.io
username: ${{ secrets.REGISTRY_USERNAME }}
Expand All @@ -121,7 +121,7 @@ jobs:
docker build . -t contoso.azurecr.io/nodejssampleapp:${{ github.sha }}
docker push contoso.azurecr.io/nodejssampleapp:${{ github.sha }}

- uses: azure/webapps-deploy@v2
- uses: azure/webapps-deploy@v3
with:
app-name: 'node-rnc'
publish-profile: ${{ secrets.azureWebAppPublishProfile }}
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- uses: azure/docker-login@v1
- uses: azure/docker-login@v2
with:
login-server: contoso.azurecr.io
username: ${{ secrets.REGISTRY_USERNAME }}
Expand All @@ -176,15 +176,15 @@ jobs:
docker build . -t contoso.azurecr.io/nodejssampleapp:${{ github.sha }}
docker push contoso.azurecr.io/nodejssampleapp:${{ github.sha }}

- uses: azure/webapps-deploy@v2
- uses: azure/webapps-deploy@v3
with:
app-name: 'node-rnc'
images: 'contoso.azurecr.io/nodejssampleapp:${{ github.sha }}'
```

#### Configure deployment credentials:

The previous sample workflow depends on user-level credentials stored as a [secret](https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets) named `AZURE_CREDENTIALS` in your repository. The value of this secret is expected to be a JSON object that represents a service principal (an identifer for an application or process) that authenticates the workflow with Azure.
The previous sample workflow depends on user-level credentials stored as a [secret](https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets) named `AZURE_CREDENTIALS` in your repository. The value of this secret is expected to be a JSON object that represents a service principal (an identifier for an application or process) that authenticates the workflow with Azure.

To function correctly, this service principal must be assigned the [Contributor]((https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#contributor)) role for the web app or the resource group that contains the web app.

Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ inputs:
description: 'Restart the app service after deployment'
required: false
sitecontainers-config:
description: 'Applies to Sitecontainers, containes a list of siteContainer specs'
description: 'Applies to Sitecontainers, contains a list of siteContainer specs'
required: false

outputs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class WebAppDeploymentProvider extends BaseWebAppDeploymentProvider {
// kudu warm up
await this.kuduServiceUtility.warmpUp();

// If provided, type paramater takes precidence over file package type
// If provided, type parameter takes precedence over file package type
if (this.actionParams.type != null && validTypes.includes(this.actionParams.type.toLowerCase())) {
core.debug("Initiated deployment via kudu service for webapp" + this.actionParams.type + "package : "+ webPackage);
}
Expand Down