Conversation
johncarl81
reviewed
Aug 15, 2022
| @@ -0,0 +1,88 @@ | |||
| #!/usr/bin/env python3 | |||
Collaborator
There was a problem hiding this comment.
Would you convert these to 4 space indentation?
johncarl81
reviewed
Aug 15, 2022
| return plume(x, y, z) | ||
|
|
||
|
|
||
| plume_base = plume_grid() |
Collaborator
There was a problem hiding this comment.
I wonder, could place the plume in gazebo with some input variables from the CLI?
Author
There was a problem hiding this comment.
Yeah any defined model you can place(spawn) in gazebo from the command line
Author
There was a problem hiding this comment.
You just gotta make sure it matches the virtual co2publisher or that we write something that looks at the current gazebo models
Also changed to just launching gazebo instead of a ros2 launch as the library arguments don't seem to be available in the ros2 launch. Note if there are multiple versions of ros/gazebo in the container this may cause issues
Author
docker exec -it `docker ps | grep dragonfly-sim | cut -d" " -f1` /bin/bash
source /opt/ros/humble/setup.bash
cd workspace/
./misc/co2_plume_spawner.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts gazebo in a mode(with libraries) so the spawner can be called.
Created a script that matches the virtual co2 publisher's plume misc/co2_plume_spawner.py
Sorry I had to open a new PR #7 would closed itself when was resting the branch one commit back and would not reopen.