Conversation
There was a problem hiding this comment.
Mostly recommendations and errors due to rebase. Some components are built multiple times in Builder and there are some mistakes that came from #59.
| :title="component.trombinoscope.title" | ||
| :members="component.trombinoscope.members" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
This component is already built higher up the Builder on line 14.
| :instagram="component.social.instagram" | ||
| :snapchat="component.social.snapchat" | ||
| :tiktok="component.social.tiktok" | ||
| :mail="component.social.mail" |
| <Carousel | ||
| :carousels="component.carousel.carousels" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
This component is built twice in the Builder. Remove one of them.
| import SocialNetworks from '~/components/Social'; | ||
| import GraphScore from '~/components/GraphScore'; | ||
| import Trombinoscope from '~/components/Trombinoscope'; | ||
| export default { |
There was a problem hiding this comment.
I'm not sure if these imports are required, there are already components like Carousel that are used without being imported.
package.json
Outdated
| "chart.js": "^2.9.4", | ||
| "core-js": "^3.17.3", | ||
| "graphql-tag": "^2.12.5", | ||
|
|
There was a problem hiding this comment.
Not important, but you should consider removing this empty line. package.json is supposed to be mostly managed by npm.
| data() { | ||
| return { | ||
| hdr: website, | ||
| bureau: bureauxJSON, |
There was a problem hiding this comment.
Consider removing the bureaux attribute in ~/static/bureaux.json and just put the data directly to avoid using bureauxJSON.bureaux and just use bureauxJSON.
{
"bureaux":[{emoji:"",nom:"",...}]
}
To :
[{emoji:"",nom:"",...}]
|
|
||
| <script> | ||
| import website from '~/static/website.json'; | ||
| import website from '~/static/bureaux.json'; |
There was a problem hiding this comment.
Rename website to bureaux.
Consider removing the bureaux attribute in ~/static/bureaux.json and just put the data directly to avoid using bureaux.bureaux and just use bureaux.
{
"bureaux":[{emoji:"",nom:"",...}]
}
To :
[{emoji:"",nom:"",...}]
| @@ -0,0 +1,1044 @@ | |||
| { | |||
There was a problem hiding this comment.
Consider removing the bureaux attribute and just put the data directly to avoid using bureauxJSON.bureaux and just use bureauxJSON when importing the file.
{
"bureaux":[{emoji:"",nom:"",...}]
}
To :
[{emoji:"",nom:"",...}]
Alos use bulma classes instead of custom classes
4 participants
rebasing page-bde from main
for now page-bde contains trombinoscope of the whole bde and a carousel for events
will update ASAP