Skip to content

Add default ruleset and add properties.json #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bio-boris wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add default ruleset and add properties.json #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e59ea
Add files via upload
bio-boris Sep 20, 2025
2a6017d
Create build_docker_image.properties.json
bio-boris Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions default_berdl_ruleset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"id": 8262062,
"name": "default_berdl_ruleset",
"target": "branch",
"source_type": "Repository",
"source": "BERDataLakehouse/.github",
"enforcement": "active",
"conditions": {
"ref_name": {
"exclude": [],
"include": [
"~DEFAULT_BRANCH",
"refs/heads/main",
"refs/heads/develop"
]
}
},
"rules": [
{
"type": "deletion"
},
{
"type": "non_fast_forward"
},
{
"type": "required_linear_history"
},
{
"type": "pull_request",
"parameters": {
"required_approving_review_count": 0,
Copy link

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting required_approving_review_count to 0 means pull requests can be merged without any code review approvals, which poses a security risk for protected branches like main and develop.

Suggested change
"required_approving_review_count": 0,
"required_approving_review_count": 1,

Copilot uses AI. Check for mistakes.
"dismiss_stale_reviews_on_push": false,
"require_code_owner_review": false,
Copy link

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling code owner review requirement means changes to critical files can be merged without oversight from designated code owners, reducing code quality and security controls.

Suggested change
"require_code_owner_review": false,
"require_code_owner_review": true,

Copilot uses AI. Check for mistakes.
"require_last_push_approval": false,
"required_review_thread_resolution": false,
"automatic_copilot_code_review_enabled": true,
"allowed_merge_methods": [
"merge",
"squash",
"rebase"
]
}
},
{
"type": "required_status_checks",
"parameters": {
"strict_required_status_checks_policy": true,
"do_not_enforce_on_create": false,
"required_status_checks": [
{
"context": "build",
"integration_id": 15368
}
]
}
},
{
"type": "copilot_code_review",
"parameters": {
"review_on_push": true,
"review_draft_pull_requests": false
}
}
],
"bypass_actors": []
}
4 changes: 4 additions & 0 deletions workflow-templates/build_docker_image.properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Run Docker Image Build",
"description": "Run Docker Image Build",
}
Loading