Skip to content

chore: add startup warning for missing PORT env variable #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
temisan0x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add startup warning for missing PORT env variable #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ function logWithTime(message) {
const app = express();
const PORT = process.env.PORT || 3000;

if (!process.env.PORT) {
console.warn(`[WARNING] PORT is not defined in environment variables - defaulting to ${PORT}.`);
}

const limiter = rateLimit({
windowMs: 15 * 60 * 1000,
max: 100,
Expand Down Expand Up @@ -47,7 +51,7 @@ async function fetchPrices() {

app.get('/api/v1/prices', async (req, res) => {
const now = Date.now();

if (priceCache.data && (now - priceCache.timestamp) < CACHE_DURATION) {
return res.json({
...priceCache.data,
Expand All @@ -60,7 +64,7 @@ app.get('/api/v1/prices', async (req, res) => {
const prices = await fetchPrices();
priceCache.data = prices;
priceCache.timestamp = now;

res.json({
...prices,
cached: false,
Expand Down