Fix TCP connection spike: disable HTTP keep-alive and add request timeouts on cached sessions#1
Draft
Fix TCP connection spike: disable HTTP keep-alive and add request timeouts on cached sessions#1
Conversation
… in login sessions Co-authored-by: flwfdd <36499196+flwfdd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with high TCP connection count leading to system freeze
Fix TCP connection spike: disable HTTP keep-alive and add request timeouts on cached sessions
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every cached
requests.Sessionholds a urllib3 connection pool (pool_connections=10, pool_maxsize=10by default) of idle open TCP sockets. With a 30-minute cache TTL, connections accumulate under load until the OS exhausts file descriptors — system freezes. After TTL expiry the cleanup thread closes all sessions and releases sockets — system auto-recovers. Matches the described symptom exactly.Changes
bit_login/login.pyConnection: closeheader on all sessions — urllib3 closes the TCP socket immediately after each response instead of returning it to the idle pool. Eliminates idle socket accumulation in cached sessions._TimeoutHTTPAdapter— thinHTTPAdaptersubclass that injects a 30-second default timeout viakwargs.setdefault. Prevents hung connections from accumulating without modifying any call site. Mounted as separate instances forhttp://andhttps://.bit_login/config.pyConnection: keep-alive→Connection: closein the base headers dict for consistency.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.