A branch that restores support for OWLQN (and doesn't need liblbgfs).#21
Open
jimwhite wants to merge 25 commits intoBLLIP:masterfrom
Open
A branch that restores support for OWLQN (and doesn't need liblbgfs).#21jimwhite wants to merge 25 commits intoBLLIP:masterfrom
jimwhite wants to merge 25 commits intoBLLIP:masterfrom
Conversation
…e comments about that.
…n1p2 to match the other current settings.
…p2 to match the other current settings.
Conflicts: second-stage/programs/wlle/Makefile
convenience scripts) on both Mountain Lion and Mavericks. Merge branch 'BLLIP_FOR_MACOS' into BLLIP_ON_MAVERICKS Conflicts: Makefile second-stage/programs/wlle/Makefile
Member
|
Sorry for taking so long to respond to this! Your work on this is very much appreciated. The context for removing the OWLQN code was when the parser was released under the Apache license. The OWLQN code is under Microsoft Research's license which (as I understand it) is incompatible with the Apache license (MSR license prohibits commercial use), so unfortunately I can't merge this into the main codebase. And yes, I completely agree that this project probably should be automake'd at some point, but I assume it would be a bit of an undertaking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (based on my BLLIP_ON_MAVERICKS PR) restores the OWLQN stuff.
I needed this in order to test on Linux because I don't have an easy way to install liblbgfs on the system I'm using. I'm not suggesting that this be merged to the master branch (I assume there was a good reason for removing OWLQN) but it may be worthwhile to have a branch for folks in a similar situation.
This version just hacks the wlle/Makefile but a nicer approach would be automake. I doubt that is really worthwhile although if this program is going to support a variety of platforms then it would be nice.