Skip to content

Code Simplification Agent: workaround for CRLF issue that was preventing PRs from being generated#17941

Merged
sebavan merged 2 commits intomasterfrom
code-simplifier-crlf-patch
Feb 23, 2026
Merged

Code Simplification Agent: workaround for CRLF issue that was preventing PRs from being generated#17941
sebavan merged 2 commits intomasterfrom
code-simplifier-crlf-patch

Conversation

@AmoebaChant
Copy link
Contributor

Filed an issue with the original tool to track fixing the root cause: github/gh-aw#17975

Copilot AI review requested due to automatic review settings February 23, 2026 20:23
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 23, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a workaround for a CRLF line ending issue that was preventing the Code Simplifier workflow from successfully creating pull requests. The issue occurs when git am applies patches to repositories with CRLF line endings - the mailbox parser strips carriage returns, causing context mismatches. The fix configures git am to preserve carriage returns during patch application.

Changes:

  • Added am.keepcr=true git configuration to preserve CRLF in patches during git am mailbox parsing
  • Added detailed comments explaining the CRLF preservation mechanism and why it's needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 23, 2026

Snapshot stored with reference name:
refs/pull/17941/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17941/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17941/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17941/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17941/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17941/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17941/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17941/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@sebavan sebavan enabled auto-merge (squash) February 23, 2026 20:40
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 23, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 23, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 23, 2026

@sebavan sebavan merged commit c9a347a into master Feb 23, 2026
30 of 31 checks passed
@sebavan sebavan deleted the code-simplifier-crlf-patch branch February 23, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants