Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,4 @@ Dockerfile.cross
*.swo
*~
.gitpod.yml
.DS_Store
2 changes: 1 addition & 1 deletion data-loader.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update -yq && \
apt-get install -yq --no-install-recommends ca-certificates && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* && \
pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 setuptools && \
pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve long-term maintainability, it's beneficial to add a comment explaining why setuptools is pinned. This will provide crucial context for future developers, preventing accidental removal of the pin and reintroduction of the bug.

    # Pin setuptools: modelscope requires pkg_resources, which is absent in newer versions.
    pip install --no-cache-dir "huggingface_hub[cli]"==0.33.1 modelscope==1.27.1 "setuptools<81" && \

rclone_version=v1.70.1 && \
arch=$(uname -m | sed -E 's/x86_64/amd64/g;s/aarch64/arm64/g') && \
filename=rclone-${rclone_version}-linux-${arch} && \
Expand Down
Loading