fix: only crons on default branch are considered #2203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: run fee bot every midnight
ci: specify branch for cron
Xeonus
approved these changes
Jul 11, 2025
Collaborator
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
- comparing the fee allocator cron job for core pool fees against this, it seems that the workflow in the branch has an environment set which the other doesn't. However, we need that for secrets mgmt of the bot
- Actions can't be triggered from branch with env context, but rather from main with a reference to the branch it should commit to
With this the workflow will:
- Trigger on schedule from main branch
- Checkout the
v3-fee-bot-cronbranch - Run your v3-fee-bot script from that branch
- Create the PR as intended
gosuto-inzasheru
temporarily deployed
to
v3-fee-bot
GitHub Actions
Inactive
gosuto-inzasheru
temporarily deployed
to
v3-fee-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.