Skip to content

Code Review#1

Open
Baowyishere wants to merge 2 commits intomasterfrom
Baowyishere-patch-1
Open

Code Review#1
Baowyishere wants to merge 2 commits intomasterfrom
Baowyishere-patch-1

Conversation

@Baowyishere
Copy link
Owner

Only some suggestions, although besides those I think Honda Boys did a very good job. Very creative theme as well.

  1. There are a lot of files in the GameManager for the pictures of the background so making a different file to store the backgrounds could help clear the amount of files in the GameManager for just managing the game.
  2. For the monsters. There aren't any javadox notes so I added a note to one of them to write for all of them to better help explain what they do. Same for some of the events.
  3. Scenes changer used a lot of boolean values so I thought you could create a method that assigns the background numbers so that booleans aren't used constantly throughout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant