-
Notifications
You must be signed in to change notification settings - Fork 3
Add a disassembler for reconstituting compiled generator expressions #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eb8680
wants to merge
113
commits into
master
Choose a base branch
from
eb-disassembler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,119
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #242
As the first (and primary) step toward full and robust support for comprehension syntax overloading, this PR adds a self-contained module
effectful.internals.disassemblythat performs symbolic execution of the CPython VM bytecode of a compiled generator expression object in order to extract an equivalent Pythonast.AST.It has one public-facing function
disassemblewhich takes a generator expression and returns an AST:This function should satisfy the following:
It currently supports a large subset of valid comprehension syntax in Python 3.12 and 3.13, including filter expressions (e.g.
if predicate(x)in(f(x) for x in xs if predicate(x))), nested loops, nested comprehensions, unpacking, structured data, mixed comprehension types, inline lambdas and more.The main features missing right now from the symbolic executor are conditional expressions (
a if b else c), multipleand/or-based conditions and chained comparisons (e.g.a < b < c), which require handling jumps with a little more care.Remaining tasks: