Add defdata patterns and Operations for polymorphic collection and Number types
#305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use infer_return_type to implement Operation.__type_rule__ * move some logic out of infer_return_type * dont add defaults * update * remove duplicate default param logic * fix and format * lint * fix semiring test * address comment
This was referenced Aug 26, 2025
Merged
Contributor
Author
|
Going to close this, the contents will land in separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #277 #296 #251
Blocked by #299Blocking #289
This draft PR uses the type inference machinery in #299 #300 to add support in
effectfulfor customOperations that take and return arbitrarily nested polymorphic collection types and higher-order functions. It does so mostly by addingdefdatapatterns andOperations for the immutable collection APIs defined in the standard librarycollections.abc, and as a result is quite straightforward to extend incrementally as needed.This PR is feature-complete and seems to work fine, but #299 needs to land on
masterand then this needs to be broken up into a sequence of self-contained smaller PRs. It also includes most of the work toward #296 as a prerequisite, and part of #251 (moving the meat ofhandler.numbersintoops.syntax) as a side quest.