Conversation
- Add Scope.admin? authorization checks to all 5 entity bulk action handlers - Rewrite bulk_update_category to use single jsonb_set query instead of N updates - Extract available_categories before category filter for correct dropdown display - Fix admin_edit_url: product.id → product.uuid, add missing /edit suffix - Replace silent rescue with Logger.warning in product_counts_by_category
ddon
pushed a commit
that referenced
this pull request
Feb 14, 2026
ddon
pushed a commit
that referenced
this pull request
Feb 14, 2026
ddon
pushed a commit
that referenced
this pull request
Feb 14, 2026
…oss-review findings Renamed AI_REVIEW.md to CLAUDE_REVIEW.md for clarity alongside MISTRAL_REVIEW.md. Added Kimi independent review identifying scalability (no pagination, in-memory filtering) and MapSet issues. Updated Claude review with cross-review section acknowledging missed findings and context on Mistral's severity claims.
timujinne
added a commit
to timujinne/phoenix_kit
that referenced
this pull request
Feb 15, 2026
- Add admin auth checks for single-record handlers in data_navigator - Move require Logger to module level in shop.ex - Filter only active products in category featured product dropdown - Add recursive circular reference validation for category parents - Prevent ancestor cycles in bulk category parent update - Split load_categories into static data cache and filtered query - Remove unused noop event handler and phx-click attributes - Remove unused MIM demo images (8.2MB)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
mix compile— no warningsmix format— formattedmix credo --strict— no issuesmix quality— all checks passed (including Dialyzer)