Closes #4096, adding range parameter to histogram functions#4078
Merged
ajpotts merged 1 commit intoBears-R-Us:masterfrom Apr 23, 2025
Merged
Closes #4096, adding range parameter to histogram functions#4078ajpotts merged 1 commit intoBears-R-Us:masterfrom
range parameter to histogram functions#4078ajpotts merged 1 commit intoBears-R-Us:masterfrom
Conversation
d351696 to
d51dafd
Compare
ajpotts
reviewed
Feb 7, 2025
ajpotts
reviewed
Feb 7, 2025
ajpotts
reviewed
Feb 7, 2025
ajpotts
reviewed
Feb 7, 2025
b281dc9 to
36a920c
Compare
range parameter to histogram functionsrange parameter to histogram functions
d541bf8 to
8fd9a7d
Compare
range parameter to histogram functionsrange parameter to histogram functions
ajpotts
reviewed
Feb 14, 2025
ajpotts
reviewed
Feb 14, 2025
e-kayrakli
reviewed
Feb 14, 2025
198d1c3 to
30a9c22
Compare
e-kayrakli
approved these changes
Feb 18, 2025
ajpotts
approved these changes
Mar 6, 2025
30a9c22 to
ee02655
Compare
jaketrookman
approved these changes
Apr 18, 2025
Contributor
Author
|
Thank you @jaketrookman for the approval. I am working to implement the last open item for this PR, which is to use |
7caf3b4 to
ebbc182
Compare
Contributor
Author
|
@ajpotts or @jaketrookman - I have made all the changed I wanted to. Could you please review? These are in the last two commits. I will rebase everything down to a single commit before merging. |
ajpotts
reviewed
Apr 22, 2025
Contributor
|
Looks good other than the accidental changes to |
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
0ccdd52 to
5caa0ba
Compare
Contributor
Author
|
FYI: I just closed and re-opened to restart the CI checks. The failure reported previously, due to failed fetch of https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz, seems transient. |
ajpotts
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4096. Required by Bears-R-Us/arkouda-contrib#179
Adds
numpy-style optionalrangeparameter to client histogram functions:histogram()histogram2d()histogramdd()Switches the histograms produced by
histogramdd()to containfloatcounts instead of integer counts, to matchnumpy.While there:
histogramdDMsg()more efficient.histogramdd()oncumprod()./and trailing whitespace.