Move to uv & update dependencies#10
Merged
risktoparkrageram merged 13 commits intomainfrom May 30, 2025
Merged
Conversation
janrito
reviewed
May 29, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
+27
to
+32
| python-version: ${{ matrix.python-version }} | ||
| python-version-file: ".python-version" |
There was a problem hiding this comment.
if you want to test in multiple python versions, you have to use the matrix reference
pyproject.toml
Outdated
| build-backend = "hatchling.build" | ||
|
|
||
| [tool.uv] | ||
| dev-dependencies = [ |
There was a problem hiding this comment.
i think this is the deprecated format of specifiying dev dependencies
pyap_beauhurst/parser.py
Outdated
| cleaned_dict["match_end"] = match.end() | ||
| # create object containing results | ||
| return address.Address(**cleaned_dict) | ||
| return address.Address( |
There was a problem hiding this comment.
is this a pydantic model? Wouldn't it be easier to just do address.Address.model_validate(cleaned_dict)
Author
There was a problem hiding this comment.
Hmm I think i tried that and mypy was still upset. Will have another look
| ("Colombie-Britannique", True), | ||
| ("New Brunswick", True), | ||
| ("Quebec", True), | ||
| ("Quebec", True), # noqa PT014 |
Author
There was a problem hiding this comment.
("Québec", True) is the same as ("Quebec", True) according to ruff
janrito
approved these changes
May 29, 2025
Author
|
thanks for the review @janrito ⚡ ✌️ 🌃 🦤 🛖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
uvfrompoetryrufffrom `black