-
Notifications
You must be signed in to change notification settings - Fork 4
Discord OAuth for SS13 sessions #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Curious how this works... |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Crossedfall
reviewed
Jun 27, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Discord OAuth support for SS13 sessions, including token generation, storage, and UI for token retrieval.
- Adds
generate_random_session_tokenutility and a newSessionmodel to store hashed tokens. - Implements Discord OAuth blueprint with callback handling and token display template.
- Registers new configs, dependencies, and fixes a typo in the Patreon resource.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/bapi/util.py | Imported secrets and added generate_random_session_token |
| src/bapi/db.py | Defined Session model with create_session method |
| src/bapi/blueprints/discord.py | Added Discord OAuth routes (/auth, /callback) |
| src/bapi/templates/token.html | Created token display template with auto-send script |
| src/bapi/templates/base.html | New base layout template |
| src/bapi/resources/patreon.py | Renamed PatreonOuathResource to PatreonOAuthResource |
| src/bapi/init.py | Registered Discord blueprint and session DB binding |
| src/bapi/config/api.yml | Added game-session-duration config key |
| pyproject.toml | Added discord-oauth2-py dependency |
Comments suppressed due to low confidence (2)
src/bapi/db.py:37
- Consider adding unit tests for
create_session, especially around invalidduration_daysand hash storage, to ensure coverage for session token generation logic.
def create_session(cls, ip, external_method, external_uid, external_display_name, duration_days):
src/bapi/db.py:51
- The
funcnamespace from SQLAlchemy is not imported, causing aNameError. Addfrom sqlalchemy import func.
valid_until=func.date_add(func.now(), text(f"INTERVAL {duration_days} DAY")),
Crossedfall
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on BeeStation/BeeStation-Hornet#12927
Adds discord OAuth support. The game database user needs permission to insert into the SS13_session table.
Adds new
private.ymloptions:For prod make sure to rebuild the container / run
poetry installdue to the updated dependencies.The Discord OAuth2 application needs the
identifyscope and an authorized callback URI matching that of[api-url]/discord/callback